[parted-devel] [PATCH] New test for probing of disk labels

[Otavio Salvador]

"Debarshi 'Rishi' Ray" <debarshi.ray at gmail.com> writes:

> Please find attached a patch introducing a new test for ped_disk_probe.
>
> +                probed = ped_disk_probe (dev);
> +                fail_if (!probed,
> +                         "Failed to probe the just created label of type: %s",
> +                         type->name);
> +                fail_if (strcmp (probed->name, type->name) != 0,
> +                         "Probe returned label of type: %s as type: %s",
> +                         type->name, probed->name);
>
> I have added the second fail_if to make sure that ped_disk_probe
> actually detects the correct disk label type. A failure would indicate
> a mismatch in ped_disk_new_fresh and ped_disk_probe.
>
> What do you think?

Ack.

Commit it.

-- 
        O T A V I O    S A L V A D O R
---------------------------------------------
 E-mail: otavio at debian.org      UIN: 5906116
 GNU/Linux User: 239058     GPG ID: 49A5F855
 Home Page: http://otavio.ossystems.com.br
---------------------------------------------
"Microsoft sells you Windows ... Linux gives
 you the whole house."