[parted-devel] [PATCH] Ignore devices where we can't create a new PedDisk
Jim Meyering
jim at meyering.net
Wed Aug 1 16:24:18 UTC 2007
David Cantrell <dcantrell at redhat.com> wrote:
> The /proc/partitions file is looked at only if /sys/block isn't
> available. On my system, I had /sys/block available and there was one
> node that showed up that caused parted to crash. That node was md0.
> There were no software RAID devices on the system at all. /sys/block/md0
> was bogus. But since libparted found it during the device probe, it
> tried to read a label from it. Crash.
Doesn't that mean the label-reading code is at fault?
If you can point me to a stack trace, I'll take a look.
Do you know how to reproduce the set-up on another system?
Or can I get ssh access to your system?
> ...
Thanks for the details.
BTW, if you keep that patch on stable-1.8.x, then you should call
ped_disk_destroy when ped_disk_new succeeds, to avoid leaking.
More information about the parted-devel
mailing list