[parted-devel] GNU Parted Official Repository: Changes to 'stable-1.8.x'

[Otavio Salvador]

 autogen.sh                           |    2 +-
 configure.ac                         |   10 +++++-----
 libparted/exception.c                |   14 +++++++-------
 libparted/fs/hfs/cache.c             |    4 ++--
 libparted/fs/hfs/reloc.c             |    8 ++++----
 libparted/fs/hfs/reloc_plus.c        |    8 ++++----
 libparted/fs/linux_swap/linux_swap.c |    2 +-
 libparted/labels/sun.c               |    6 +++---
 8 files changed, 27 insertions(+), 27 deletions(-)

New commits:
commit c30bd188e757034457eb2c72b1ef5e083b48b19f
Author: Jim Meyering <jim at meyering.net>
Date:   Mon Feb 12 23:35:30 2007 +0100

    Compile warning-free with "gcc -Wall -Wshadow".
    
    Hello,
    
    I find that keeping code warning-free (wrt gcc -Wall -Wshadow)
    makes it easier to avoid certain classes of bugs.
    
    Compiling with gcc -Wall -Wshadow evoked a few warnings
    on a Debian/unstable system.  Here are patches to fix those:
    
    * libparted/exception.c (default_handler): Rename parameter "ex"
    to "e", to avoid shadowing file-scoped global.
    * libparted/fs/linux_swap/linux_swap.c (_generic_swap_probe): Add a
    "can't happen" (with current callers) "default: goto error" clause
    in a switch to avoid a may-be-used-uninitialized warning.
    (_generic_swap_clobber): Likewise.
    * libparted/fs/hfs/reloc_plus.c (hfsplus_pack_free_space_from_block):
    Rename local variable "div" to "divisor", to avoid shadowing
    the function in <stdlib.h>.
    * libparted/fs/hfs/reloc.c (hfs_pack_free_space_from_block): Likewise.
    * libparted/fs/hfs/cache.c (hfsc_cache_add_extent): Rename parameter
    "index" to "ref_index" to avoid shadowing the <string.h> function.
    * libparted/labels/sun.c (sun_partition_enumerate): Rename local
    variable "i" to "j", to avoid shadowing another local.
    
    Signed-off-by: Jim Meyering <jim at meyering.net>

commit 78c0516f7520e13bbeb49e8fc366beda23a32e60
Author: Jim Meyering <jim at meyering.net>
Date:   Mon Feb 12 23:38:07 2007 +0100

    configure.ac: Add LOCALEDIR definition to CFLAGS only once.
    
    I noticed that there were two identical lines in configure.ac,
    adding the same LOCALEDIR definition to CFLAGS.
    This change removes the latter.
    
    * configure.ac: Add LOCALEDIR definition to CFLAGS only once.
    
    Signed-off-by: Jim Meyering <jim at meyering.net>

commit a0383050cf4d490c2299bc08cc84f909324236ef
Author: Jim Meyering <jim at meyering.net>
Date:   Mon Feb 12 23:30:46 2007 +0100

    Work with automake-1.10.
    
    I've just tried building parted from scratch (running ./autogen.sh
    after git-clone) and hit a couple of snags:
    
    Without aclocal's -I m4, ./autogen.sh produced this:
    
      configure.ac:192: warning: macro `AM_GNU_GETTEXT_VERSION' not found in library
      configure.ac:193: warning: macro `AM_GNU_GETTEXT' not found in library
      configure.ac:192: error: possibly undefined macro: AM_GNU_GETTEXT_VERSION
            If this token and others are legitimate, please use m4_pattern_allow.
            See the Autoconf documentation.
    
    With automake-1.10, I got this:
    
        parted/Makefile.am:5: compiling `command.c' with per-target flags requires `AM_PROG_CC_C_O' in `configure.ac'
    
    Here's a patch that fixes those and also removes some trailing blanks.