[parted-devel] policy regarding unused functions?

[Otavio Salvador]

Jim Meyering <jim at meyering.net> writes:

> Otavio Salvador <otavio at debian.org> wrote:
>> Jim Meyering <jim at meyering.net> writes:
>>
>>> Hello,
>>>
>>> I'm preparing a patch that makes the build warning free,
>>> and found some unused functions in libparted/labels/fdasd.c.
>>> Here they are:
>>>
>>> 	(fdasd_partition_type):
>>> 	(fdasd_write_vtoc_labels):
>>> 	(fdasd_change_volser):
>>> 	(fdasd_check_volser):
>>> 	(fdasd_reread_partition_table):
>>
>> On this specific case I think that would be better to leave fdasd out
>> of your patch. We have a fix on Debian package that needs to be ported
>> (from 1.7 release) and then dasd could be cleaned up.
>
> I'm easy.
> But you say "fdasd", then "dasd".  I presume the latter should be "fdasd".
>
> However, are you worried about the risk of a merge conflict?
> Unless it's more than a strategic fix, they shouldn't be changing dead code

Well, I don't worry too much. David said to you to remove them and
since he's the one who merged it and probably the one who will work on
that too I think you can remove them.

-- 
        O T A V I O    S A L V A D O R
---------------------------------------------
 E-mail: otavio at debian.org      UIN: 5906116
 GNU/Linux User: 239058     GPG ID: 49A5F855
 Home Page: http://otavio.ossystems.com.br
---------------------------------------------
"Microsoft sells you Windows ... Linux gives
 you the whole house."