[parted-devel] [PATCH] Fix the mkfs final-group-block-too-short bug.
Otavio Salvador
otavio at debian.org
Tue Jun 12 19:48:55 UTC 2007
Jim Meyering <jim at meyering.net> writes:
> Ironically, after taking the time to record-as-failing the
> existing mkfs problem, this morning I noticed the fix, then
> in testing, found the off-by-one bug:
>
> Fix the mkfs final-group-block-too-short bug.
> mkfs would fail for certain sizes resulting in a final group-block
> that was too small to accommodate the minimum number of admin blocks.
> There was already work-around code for when a decremented "numgroups"
> was 1. This change applies that work-around code for larger values of
> numgroups, too. Also, there was an off-by-one error in the guard test
> that would allow a few too-small partition sizes to slip through and
> provoke the error (see tests/t2000-mkfs.sh for two examples).
> This change fixes that, too.
>
> Signed-off-by: Jim Meyering <jim at meyering.net>
Ack.
--
O T A V I O S A L V A D O R
---------------------------------------------
E-mail: otavio at debian.org UIN: 5906116
GNU/Linux User: 239058 GPG ID: 49A5F855
Home Page: http://otavio.ossystems.com.br
---------------------------------------------
"Microsoft sells you Windows ... Linux gives
you the whole house."
More information about the parted-devel
mailing list