[parted-devel] [PATCH] Avoid unnecessary writes in test scripts.

Håkon Løvdal hlovdal at gmail.com
Thu Jun 14 19:56:35 UTC 2007


On 11/06/07, Jim Meyering <jim at meyering.net> wrote:

This change

>      'erase the left-over label' \
> -    'dd if=/dev/zero of=$dev bs=$N count=1 2> /dev/null'
> +    'dd if=/dev/zero of=$dev bs=1K count=1 2> /dev/null'

is different from all the others, like this for instance

>      'create a file too small to hold a fat32 file system' \
> -    'dd if=/dev/zero of=$dev bs=$N count=1 2> /dev/null'
> +    'dd if=/dev/null of=$dev bs=1 seek=$N 2> /dev/null'
and
>     'setup' '
> -    dd if=/dev/zero of=$dev bs=10M count=1 2> /dev/null &&
> +    dd if=/dev/null of=$dev bs=1 seek=10M 2> /dev/null &&

and to me it looks like an error. Is it?

BR Håkon Løvdal


More information about the parted-devel mailing list