[parted-devel] Re: indentation changes render parted/ui.c nearly unmergeable

[Jim Meyering]

"Debarshi 'Rishi' Ray" <debarshi.ray at gmail.com> wrote:

>>> Is this the mechanism that will reject any patch that does not conform to
>>> the coding standard? If yes, then fantastic. To augment it we can still
>
>> That's the goal.  I don't know if it's attainable.
>> It might be too draconian.
>
> It would save a lot of headache later on. If we have a clearly stated
> coding style, then it is not too harsh. Then everybody knows how to
> write what.

You're preaching to the choir.

>> It might be nearly as good to have a way to check manually,
>> e.g., "make check-indentation".  Then there won't be the hook-related
>> overhead (and complexity) of checking at every push.  Think what happens
>> when your carefully prepared, locally-committed patch cannot be pushed
>> because of the hook.  You'd have to redo it to get past the hook.
>
> Can't we have the hook on our local repositories as well?

Sure, but that's up to the individual.
Can't be mandated.