[parted-devel] Parted on GNU Hurd based systems

[Jim Meyering]

"Debarshi 'Rishi' Ray" <debarshi.ray at gmail.com> wrote:
> I have attached the final version of the patch using 'git diff' on the

Never say final :-)

Have you considered keeping just the 3-argument sig-handlers
and writing a one-argument stub handler for each that merely
calls the 3-argument one (with a NULL 2nd arg).
That would avoid a lot of the duplication.

-----------------
E.g., then we won't see 6(!) of these ugly blocks:

        #ifdef HAVE_LIBREADLINE
        _dump_history ();
        #endif

(In a separate delta, of course)
each should each be replaced by a single line:

        _dump_history ();

Just add this above:

  #else
  # define _dump_history() /* empty */

If you want to do this just say the word.
Otherwise I will.