[parted-devel] porting to FreeBSD

[Siavosh Benabbas]

Hi,
Thanks for your time.
1) I saw your patch after sending mine. I am not sure if it compiles
on FreeBSD as sigaction is defined there but is not used. I will check
this and simplify my patch if possible.
2) No there is no specific reason to use memcpy. The way it is
implemented in FreeBSD memcpy handles overlaps but I totally agree
with your argument. I will change it to memmove.
3) I tried not to change the indentation of existing files. I will
change all the files to the new format. Do you know of any way to hint
emacs to use this style when it opens files in this directory? A
directive in the files perhaps? This would make my life easier as
emacs automatically indents the text you are typing/editing.

Thanks,
Siavosh

On 3/6/07, Debarshi 'Rishi' Ray <debarshi.ray at gmail.com> wrote:
> > I have created a new version of the FreeBSD patch.
>
> Line 213 in parted/table.c would be:
> temps = (char *) *s;
> instead of:
> temps = *s;
>
> One more thing. It seems that you are using TABs for indentation.
> Since different editors interpret TAB differently, it is better if you
> could use blank spaces instead. Currently 8 blank spaces seems to be
> the norm, which may change to 4 later on when we reformat the whole
> code and make it uniform.
>
> Hence for the time-being it would be nice if you could replace those
> TABs with 8 blank spaces.
>
> Happy hacking,
> Debarshi
> --
> GPG key ID: 63D4A5A7
> Key server: pgp.mit.edu
>