[parted-devel] avoid printf, when easy to do
Debarshi 'Rishi' Ray
debarshi.ray at gmail.com
Wed Mar 7 21:06:09 CET 2007
> > --- a/libparted/fs/ext2/ext2_inode_relocator.c
> > +++ b/libparted/fs/ext2/ext2_inode_relocator.c
> > @@ -309,7 +309,7 @@ static int doscan(struct ext2_fs *fs, struct ext2_inode_relocator_state *state)
> > }
> >
> > if (fs->opt_verbose)
> > - fprintf(stderr, "\n");
> > + fputc ('\n', stderr);
> I don't know if we should or not also change the indentation on the
> changed lines. I'm ok with it but I would like to hear from the others
> too.
>
> There're a lot of indentation changes on the patch.
The problem is that when I delete 'printf' and type 'puts' in its
place the TAB causes the whole alignment to misbehave in Emacs. Even
removing the 'stderr' from being the first argument to the be the
second causes this problem.
Happy hacking,
Debarshi
--
GPG key ID: 63D4A5A7
Key server: pgp.mit.edu
More information about the parted-devel
mailing list