[parted-devel] Re: Enforcement of indentation

[David Cantrell]

On Thu, 2007-03-08 at 12:57 -0300, Otavio Salvador wrote:
> Anant Narayanan <anant at kix.in> writes:
> 
> >> While I think it's bad to reformat all code and commit a very huge
> >> change for indentation fix I also think is boring to always take care
> >> to verify the whole file, make a patch to enforce the style and then
> >> go fix what you want.
> >
> > I'm all for a hook script on the server-side that automatically  
> > corrects indentation errors (by changing whitespaces to 8 spaces  
> > flat). astyle does it no?
> 
> astyles a also indent does too.
> 
> I don't think automatic change of code is good thing. I much prefer a
> hook that _checks_ if the indentation is OK or not.

A script that checks and warns (either by email or to the terminal when
committing) is fine by me.  I don't want a script that automatically
changes the code on commit though.  That seems a bit draconian.

-- 
David Cantrell <dcantrell at redhat.com>
Red Hat / Westford, MA
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.alioth.debian.org/pipermail/parted-devel/attachments/20070308/d484ec06/attachment.pgp