[parted-devel] [PATCH] No longer require "srcdir=." when running a test manually.

[Otavio Salvador]

Jim Meyering <jim at meyering.net> writes:

> Thanks for the quick feedback.

No problem.

> Otavio Salvador <otavio at debian.org> wrote:
>>> +init.sh: Makefile.in
>>> +	echo 'srcdir=$(srcdir)'          > $@-t
>>> +	echo '. $$srcdir/test-lib.sh' >> $@-t
>>> +	mv $@-t $@
>>                                   ^^^^^^^^^^ bad indentation
>
> True.  Good reason not to use such alignment: it rots too easily.
> Here's a patch with no chance for indentation:
>
> diff --git a/tests/Makefile.am b/tests/Makefile.am
> index 2948ae2..1d2a043 100644
> --- a/tests/Makefile.am
> +++ b/tests/Makefile.am
> @@ -8,3 +8,9 @@ TESTS_ENVIRONMENT = \
>
>  EXTRA_DIST = \
>    $(TESTS) test-lib.sh
> +
> +CLEANFILES = init.sh
> +all: init.sh
> +init.sh: Makefile.in
> +	( echo 'srcdir=$(srcdir)'; echo '. $$srcdir/test-lib.sh' ) > $@-t
> +	mv $@-t $@

Ah! Much better :-D

<...>
>>> -test_expect_success \
>>> -    'create expected output file' \
>>> -    'test $fail = 0'
>>> +test_expect_success 'create expected output file' 'test $fail = 0'
>>
>> This shouldn't be done on same patch.
>
> Considering that is such a small, zero-semantic-content change,
> I deliberately chose not to put it in a patch all by itself.
> IMHO, it's not even worth a log entry.

Well, while it's trivial and without semantic changing I still prefer
to avoid those changes. It's the same case when we deny indentation
fixes together with other patches.

Please, review it.

-- 
        O T A V I O    S A L V A D O R
---------------------------------------------
 E-mail: otavio at debian.org      UIN: 5906116
 GNU/Linux User: 239058     GPG ID: 49A5F855
 Home Page: http://otavio.ossystems.com.br
---------------------------------------------
"Microsoft sells you Windows ... Linux gives
 you the whole house."