[parted-devel] FYI/TODO: massive duplication in parted.c
Otavio Salvador
otavio at debian.org
Mon May 14 16:57:44 UTC 2007
Jim Meyering <jim at meyering.net> writes:
> Whoa!
> There is a very unhealthy amount of duplication in parted.c: at least
> do_mkpart and do_mkpartfs share most of their 170-line function bodies,
> verbatim. Also, do_mkfs and do_mkpartfs have big blocks in common.
>
> This probably doesn't matter, but just in case any of that code
> survives the upcoming UI rewrite, now we all know this would make a
> good new-developer project.
Yes, there's a bunch of bad written code there. Our library has a good
quality of code while the UI doesn't.
Leandro should have something to show up in few days/weeks?
--
O T A V I O S A L V A D O R
---------------------------------------------
E-mail: otavio at debian.org UIN: 5906116
GNU/Linux User: 239058 GPG ID: 49A5F855
Home Page: http://otavio.ossystems.com.br
---------------------------------------------
"Microsoft sells you Windows ... Linux gives
you the whole house."
More information about the parted-devel
mailing list