[parted-devel] [PATCH] mkpartfs ext2 2 10 would erroneously report "file system too small"

[Otavio Salvador]

Jim Meyering <jim at meyering.net> writes:

>         mkpartfs ext2 2 10 would erroneously report "file system too small"
>         for some small (single-group) partitions.  It would also fail to
>         report "file system too small" in some cases, and instead continue
>         on to into inode-allocation code where it'd report "File system full!"
>         * libparted/fs/ext2/ext2_mkfs.c (compute_block_counts): New function,
>         factored out of...
>         (ext2_mkfs): ...here.  Call compute_block_counts rather than
>         open-coded it.  When decrementing numblocks, call compute_block_counts
>         again, to recompute all of the derived values.
>         Require at least 14 free blocks in a 16-inode-per-group partition.
>         * tests/t1500-small-ext2.sh: New file.  Test for the above.
>         * tests/Makefile.am (TESTS): Add t1500-small-ext2.sh.

All this looks good but I'd like to ask if you might try to write a
test also on the library unittesting so we can know if the library
isn't broken again too...

Can you try?

-- 
        O T A V I O    S A L V A D O R
---------------------------------------------
 E-mail: otavio at debian.org      UIN: 5906116
 GNU/Linux User: 239058     GPG ID: 49A5F855
 Home Page: http://otavio.ossystems.com.br
---------------------------------------------
"Microsoft sells you Windows ... Linux gives
 you the whole house."