[parted-devel] [PATCH] Make all tests get their initialization from the same place.

[Otavio Salvador]

Jim Meyering <jim at meyering.net> writes:

> One test used the old approach of sourcing test-lib.sh
> directly, rather than sourcing the generated init.sh.
> It doesn't currently make any difference when running
> the test via "make check", but it would fail with some
> patches I'm preparing:
>
> 	Make all tests get their initialization from the same place.
> 	* tests/t2000-mkfs.sh: Get initialization via ". ./init.sh",
> 	not via ". ./test-lib.sh".
> 	* Makefile.maint (sc_test_init): New test, to ensure we stay consistent.
>
> Signed-off-by: Jim Meyering <jim at meyering.net>

Ack but check bellow before commit.

> ---
>  Makefile.maint      |   15 +++++++++++++++
>  tests/t2000-mkfs.sh |    2 +-
>  2 files changed, 16 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile.maint b/Makefile.maint
> index ccb7370..d7b6aaa 100644
> --- a/Makefile.maint
> +++ b/Makefile.maint
> @@ -179,6 +179,21 @@ sc_changelog:
>  	  { echo '$(ME): found unexpected prefix in a ChangeLog' 1>&2;	\
>  	    exit 1; } || :
>
> +test_file_names = \
> +  $(CVS_LIST_EXCEPT) | grep -E '/t[0-9].*\.sh$$'
> +# Each test must source ./init.sh

I think the comment should be placed _before_ test_file_names. What do
you think?

-- 
        O T A V I O    S A L V A D O R
---------------------------------------------
 E-mail: otavio at debian.org      UIN: 5906116
 GNU/Linux User: 239058     GPG ID: 49A5F855
 Home Page: http://otavio.ossystems.com.br
---------------------------------------------
"Microsoft sells you Windows ... Linux gives
 you the whole house."