[parted-devel] [PATCH]: Don't fail all tests when "." lacks O_DIRECT support.

Otavio Salvador otavio at debian.org
Wed May 23 20:21:46 UTC 2007


Jim Meyering <jim at meyering.net> writes:

> I often build tools on a tmpfs file system (it's faster), and
> found that parted tests always failed there.  That's because it tries
> to open the "device" (a file) with O_DIRECT, and at least the linux tmpfs
> driver always fails with EINVAL in that case.
>
> So here's a patch that makes it work.
> Since the test may require writing in a directory like /tmp,
> to which others typically have write access, it is particularly
> careful about security (see the mkdtemp script below), in case
> "make check" is run by e.g., root.

Great! Good work :-D

Ack. :-)

-- 
        O T A V I O    S A L V A D O R
---------------------------------------------
 E-mail: otavio at debian.org      UIN: 5906116
 GNU/Linux User: 239058     GPG ID: 49A5F855
 Home Page: http://otavio.ossystems.com.br
---------------------------------------------
"Microsoft sells you Windows ... Linux gives
 you the whole house."



More information about the parted-devel mailing list