[parted-devel] [PATCH][RFC] Modified log to base 2 calculation

[Gary L. Greene Jr.]

On Tuesday 13 November 2007 11:09:16 pm Frodo Baggins wrote:
> On 11/14/07, Debarshi 'Rishi' Ray <debarshi.ray at gmail.com> wrote:
> > I have looked into it properly, but if this is correct then you should
> > remove the following line as well:
> >
> > /* FIXME: this can probably be done more efficiently */
>
> True, but I wanted to get this acked before that. More specifically,
> 1) Is this really better than the old implementation? I checked it for
> sanity(correctness), not performance. From my review, this code has a
> upper bound on how many passes it takes to calculate the logarithm and
> so may be better than before the change.
> 2) Is it acceptable to reuse code from wikipedia? Is the content
> (under GFDL) acceptable in parted code?
>
> Also, can the following comment be removed?
> /* FIXME: move this out to the prospective math.c */
> Or is there a plan to do this?
>
> Regards,
> Frodo B
>
> _______________________________________________
> parted-devel mailing list
> parted-devel at lists.alioth.debian.org
> http://lists.alioth.debian.org/mailman/listinfo/parted-devel

Actually, from the read of the article, this appears to originate from 
Warren Jr., Henry S. (2002), Hacker's Delight, Addison Wesley, pp. pp. 83.
From the read of the Copyright page from the book (obtained from Google Book 
Search [isbn:9780201914658]) [1], it appears that Wikipedia legally should 
not be using _any_ direct references to this book without the prior written 
permission of the publisher, especially in the form of code snippets. This 
means that unfortunately, this snippet, unless you could personally 
conceivably write this example, should not be used without their permission. 
Sucks, but it's true. I've run into the same issue with one of my books about 
KDE, where the examples were licensed strangely.


[1]
http://books.google.com/books?id=iBNKMspIlqEC&pg=PA14&dq=isbn:9780201914658&sig=I0eAAiXKi7rmcDD7APfL4FEVHy8#PPP6,M1



-- 
Gary L. Greene, Jr.
Sent from: peorth.tolharadys.net
 23:19:49 up 1 day,  3:48,  1 user,  load average: 0.05, 0.16, 0.30
==========================================================================
Developer and Project Lead for the AltimatOS open source project
Volunteer Developer for the KDE open source project
See http://www.altimatos.com/ and http://www.kde.org/ for more information
==========================================================================

Please avoid sending me Word or PowerPoint attachments.