[parted-devel] [Parted-edge] [RFC][PATCH] Remove alloca from libparted/arch/linux.c
Jim Meyering
jim at meyering.net
Thu Sep 6 07:54:19 UTC 2007
Otavio Salvador <otavio at debian.org> wrote:
> Jim Meyering <jim at meyering.net> writes:
>
>> I think it would be worthwhile (long term) to convert the other way,
>> e.g., ped_free -> free, ped_malloc -> malloc, etc.
>
> But wouldn't the exception handling be a good thing in this case?
?!? This sort of "exception handling" is never a good thing.
Its use makes for ugly, unmaintainable code.
One problem is that what libparted calls "exception handling"
is an ugly kludge that can make the library code produce output
and/or try to read an interactive reply from the user
(things libraries must not do, in general). In addition,
how the handler behaves depends on static state,
which is another big no-no for a library.
More information about the parted-devel
mailing list