[parted-devel] [PATCH] Fall back to not using O_DIRECT

Olaf Hering olh at suse.de
Wed Aug 6 18:37:23 UTC 2008


On Wed, Aug 06, Jim Meyering wrote:

> Olaf Hering <olh at suse.de> wrote:
> 
> > On Wed, Aug 06, Jim Meyering wrote:
> >
> >> I agree wholeheartedly that arch-specific #ifdefs are best
> >> avoided, but am a little leery of removing O_DIRECT altogether.
> >> However, I'm currently leaning towards accepting this.
> >> Has this change been tested much?
> >
> > Its a result of this bug, the patch is used since one year.
> >
> > https://bugzilla.novell.com/show_bug.cgi?id=290087
> 
> Thanks.
> It's reassuring to know it's gotten some exposure.
> 
> Can I expect you to adjust your patch to detect
> fsync and close failures?

How should it handle the failures? 
parted cant do anything about the error in practice.



More information about the parted-devel mailing list