[parted-devel] History patchset

Jim Meyering jim at meyering.net
Wed Feb 20 17:08:17 UTC 2008


"Matt Davis" <mattdavis9 at gmail.com> wrote:
> Jim, et all
> I took another peek.  It should not be too much work to roll this
> history change into parted and out from the library.  Unfortunately
> that would require a global instance of a history manager, as I cannot
> bind a manager pointer in with any other library structures, such as
> the PedDevice which previously contained a pointer to the history
> manager.  I do not want to muck with the command callback routines
> (do_<xxxxx>), so a global singleton seems the most logical.  If that
> is cool I will continue in that direction.  I only want to implement
> this if it will be deemed useful.  I believe it is useful, but I value
> the opinion of yourself and the rest of the parted team over my
> opinion.

Hi Matt,

Not quite sure what you're suggesting...
However, adding a global variable is acceptable only if no
library code uses it.



More information about the parted-devel mailing list