[parted-devel] [PATCH] detect device map type

[Guido Günther]

Hi Jim,
On Thu, Jun 05, 2008 at 03:19:38PM +0200, Jim Meyering wrote:
> I'm looking through your patches.
> Running the new test as root elicits a failure for me,
Could you paste that one. We rely on having multipath-tools around and
the apropriate kernel modules loaded. Maybe we should add this to the
test.

> so I'm investigating that.  Looking at the file you added,
> dm-utils.sh, it seems to come from lvm's tests/lvm-utils.sh, but
> with some changes.  Or maybe you took an older version, verbatim?
> If you made changes, please list them with an explanation of why
> you made them.  Otherwise, I'll use the latest from lvm's CVS repository.
Besides removing some lvm specific functions I needed to change some
variable names:

@@ -110,12 +62,12 @@
 # set up private /dev and /etc
 init_root_dir_()
 {
-  test -n "$test_dir_rand_" \
+  test -n "$test_dir_" \
     || error "Internal error: called init_root_dir_ before" \
-      " defining $test_dir_rand_"
+      " defining $test_dir_"
 
   # Define these two globals.
-  G_root_=$test_dir_rand_/root
+  G_root_=$test_dir_/root
   G_dev_=$G_root_/dev
 
   export LVM_SYSTEM_DIR=$G_root_/etc
@@ -137,6 +89,7 @@
 EOF
 }
 
-if test $(this_test_) != 000-basic; then
+if test $(this_test_) = t6000; then
   init_root_dir_
 fi
+

> By the way, normally, facts like that would be noted in
> a commit log/ChangeLog entry something like this:
> 
>   * tests/dm-utils.sh: New file.  Copied from lvm's tests/lvm-utils.sh.
Sure. Omission on my end. Sorry.
 -- Guido