[parted-devel] [PATCH] detect device map type

[Jim Meyering]

Guido Günther <agx at sigxcpu.org> wrote:
> On Fri, May 09, 2008 at 01:51:04PM -0300, Otavio Salvador wrote:
>> I've not tested the patch yet but for that be commited we'll need to
>> do a paperwork to give the copyright to Free Software Fundation. Are
>> you willing to sign it?
> I do have that for glibc already but I guess we'd need a new one here.
>
>> Besides that, it would be nice to write a test case for that so we can
>> make sure to not broke it in future. Can you take a look on that too?
> We'd need a dependency on losetup and dmsetup for that and the test
> would have to be executed as root. If this is worth the trouble could
> you point a testcassee that does something similar?

Sure.
Parted already has root-only tests; "grep privileges_required_ tests/*".
For portable losetup-using tests, see lvm's tests/.  If you prefer,
just write a few stand-alone sequences of commands that exercise the
new code and clean up afterward, and I'll convert them into test scripts.

> Can we apply the patch in the meantime?

We'll have to wait for copyright paperwork to go through, so please
start that process ASAP.  It usually takes a couple weeks.

I'm sure we can put the tests together in time.

As for copyright paperwork, if you don't have forms handy, see
the "Copyright assignment" section in this:

  http://git.sv.gnu.org/gitweb/?p=coreutils.git;a=blob;f=HACKING;hb=HEAD