[parted-devel] leaks and errors, oh-my!

[Jim Meyering]

Otavio Salvador <otavio at debian.org> wrote:
> Jim Meyering <jim at meyering.net> writes:
>> diff --git a/libparted/labels/gpt.c b/libparted/labels/gpt.c
>> index 8bb9554..5be0235 100644
...
>> +        pth_free (gpt);
>>  	return 1;
>>
>>  error_delete_all:
>
> Bad indent.

Fixed.

Having to waste time with nearly every patch, adjusting to
globally-inconsistent indentation like this is why I'll probably end up
making things consistent, once (if ever) there are few enough outstanding
patches.

>> diff --git a/libparted/labels/gpt.c b/libparted/labels/gpt.c
...
>>  	uint32_t ptes_crc;
>> -        uint8_t* pth_raw = ped_malloc (pth_get_size (disk->dev));
>> +        uint8_t* pth_raw;
>>  	GuidPartitionTableHeader_t* gpt;
...
> I think you might fix this indenting (it looks that it was already
> wrong before).

Might as well.

Thanks for the feedback.