[parted-devel] [PATCH] Correctly name virtio devices.

[Joel Granados]

On Tue, Mar 31, 2009 at 09:17:53PM -0300, Otavio Salvador wrote:
> >  include/parted/device.h |    3 +-
> >  libparted/arch/linux.c  |  101 ++++++++++++++++++++++++++++-------------------
> >  parted/parted.c         |    2 +-
> >  3 files changed, 63 insertions(+), 43 deletions(-)
> 
> I fully agree with it just I think tou should split it in two patches;
> one to organize the code and another to really add it.

This was a question that I asked myself when I created the patch.  It
was between move a chunk of the code and avoid two ifdef or create
another ifdef.  I chose to leave the code with just one ifdef with the
hope of maintaining readability (put stuff that is related together).  I
think the order change is necessary in this case, if we want to keep
just one ifdef.

regards.
> 
> -- 
> Otavio Salvador                  O.S. Systems
> E-mail: otavio at ossystems.com.br  http://www.ossystems.com.br
> Mobile: +55 53 9981-7854         http://projetos.ossystems.com.br

-- 
Joel Andres Granados
Brno, Czech Republic, Red Hat.