[parted-devel] [PATCH v2 1/2] tests: t2300-dos-label-extended-bootcode.sh: various fixes

[Petr Uzel]

* fix typo where only first 400B of fake bootcode was installed
* use bootcode_size variable and increase its value from 440 to 446
* do not use /dev/urandom since it might not exist

Signed-off-by: Petr Uzel <petr.uzel at suse.cz>
---
 tests/t2300-dos-label-extended-bootcode.sh |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/tests/t2300-dos-label-extended-bootcode.sh b/tests/t2300-dos-label-extended-bootcode.sh
index f2f3a83..a0dd2e9 100755
--- a/tests/t2300-dos-label-extended-bootcode.sh
+++ b/tests/t2300-dos-label-extended-bootcode.sh
@@ -22,9 +22,8 @@ test_description='Ensure parted preserves bootcode in extended partition.'
 
 require_512_byte_sector_size_
 
-# Note: the bootcode size is 440B
-
 dev=loop-file
+bootcode_size=446
 
 test_expect_success \
   'Create the test file' \
@@ -47,12 +46,13 @@ test_expect_success 'Expect no output' 'compare out /dev/null'
 
 test_expect_success \
   'Install fake bootcode' \
-  'dd if=/dev/urandom of=$dev bs=1c seek=16384 count=400 \
-    conv=notrunc > /dev/null 2>&1'
+  'printf %0${bootcode_size}d 0 > in &&
+   dd if=in of=$dev bs=1c seek=16384 count=$bootcode_size \
+      conv=notrunc > /dev/null 2>&1'
 
 test_expect_success \
   'Save fake bootcode for later comparison' \
-  'dd if=$dev of=before bs=1 skip=16384 count=440 > /dev/null 2>&1'
+  'dd if=$dev of=before bs=1 skip=16384 count=$bootcode_size > /dev/null 2>&1'
 
 test_expect_success \
   'Do something to the label' \
@@ -61,7 +61,7 @@ test_expect_success 'Expect no output' 'compare out /dev/null'
 
 test_expect_success \
   'Extract the bootcode for comparison' \
-  'dd if=$dev of=after bs=1 skip=16384 count=440 > /dev/null 2>&1'
+  'dd if=$dev of=after bs=1 skip=16384 count=$bootcode_size > /dev/null 2>&1'
 
 test_expect_success \
   'Expect bootcode has not changed' \
-- 
1.6.3.3


-- 
Best regards / s pozdravem

Petr Uzel, openSUSE Community Multiplier Team
-----------------------------------------------------------------
SUSE LINUX, s.r.o.                          e-mail: puzel at suse.cz
Lihovarská 1060/12                          http://www.suse.cz
190 00 Prague 9, CR                             
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/parted-devel/attachments/20090826/762998fe/attachment.pgp>