[PATCH 1/2] build: make it clear which sector size is in use upon test failure

Jim Meyering meyering at redhat.com
Wed Dec 9 16:20:47 UTC 2009


* Makefile.am (ss-1024 ss-2048 ss-4096): New targets.
Before this, top-level "make check" would lead to four separate
runs through all the regression tests, one for each of the following
simulated sector sizes: 1024 2048 4096, and one more for the native
(usually 512), and it was not easy to tell which sector size was
in use for a failing test.  Now, we still perform exactly the same
tests, but the sector size is now part of each target name.
---
 Makefile.am |   10 +++++++---
 1 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index 3d0ce15..0e80967 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -76,13 +76,17 @@ MAINTAINERCLEANFILES += \
   aclocal.m4    \
   configure

+.PHONY: ss-1024 ss-2048 ss-4096
+ss-1024 ss-2048 ss-4096:
+	PARTED_SECTOR_SIZE=$(ss-,,$@) $(MAKE) check-recursive
+
 # Run the regression test suite with different settings,
 # to ensure it works with simulated partition sizes > 512.
 .PHONY: check-other-sector_sizes
 check-other-sector_sizes:
-	PARTED_SECTOR_SIZE=1024 $(MAKE) check-recursive
-	PARTED_SECTOR_SIZE=2048 $(MAKE) check-recursive
-	PARTED_SECTOR_SIZE=4096 $(MAKE) check-recursive
+	$(MAKE) ss-1024
+	$(MAKE) ss-2048
+	$(MAKE) ss-4096

 check: check-other-sector_sizes

--
1.6.6.rc0.285.g73651




More information about the parted-devel mailing list