[parted-devel] [PATCH] [RFC] Do not automatically update GPT label in interactive mode

Jim Meyering jim at meyering.net
Tue Feb 17 08:39:48 UTC 2009

Jim Meyering <jim at meyering.net> wrote:
> In the process, I discovered a GPT-related bug that
> would provoke a failed assertion.  So I fixed that.  Patch below.
> Would you like to write the test case for *it*?
> If so, please name it t0201-gpt.sh, since it'll be
> very similar to the one below (which has a FIXME
> comment I plan to address before pushing).
> My plan for tomorrow:
>   - apply your patch, and test a little
>   - address FIXME comment in the test script below
>   - ensure that the test passes
>   - push your patch and the test-adding one


Here are the results of the above.

Changes I've made:
  - adjusted your commit log comments (it's not specific to
      interactive use)
  - added a "default: break;" case, to make that choice explicit,
      and to avoid compile-time warnings
  - addressed the FIXME comment in my test, made quoting more
      consistent, and tweaked a string or two

I'll wait an hour or two, in case you have comments.

> If you write the test to exercise my patch,
> (or tell me you'd rather not, in which case I'll do it),
> I'll push those two change sets, too.

More information about the parted-devel mailing list