[parted-devel] [PATCH] Properly sync partitions with operating system

[Jim Meyering]

Joel Granados <jgranado at redhat.com> writes:
> This is my vim configuration saying.  "I'm editing a C file, lest use
> tabs".  I was conscious of the fact that I was doing this and did not
> correct it because IMO tabs are prettier in C code.

In parted, please retain existing formatting as much as possible
on lines you do not modify.  And use the same (spaces or TAB)
indentation policy as in the surrounding code.
Yes, this is a chore, but until/unless we go the massively-disruptive
route of reformatting everything, it's the only approach that is
sustainable.

> I guess modifying
> the diff is not at all difficult, but I still have something in the back
> of my mind that says: "we should be coding with tabs for this project".
> Additionally.  Are there specific code conventions in the parted
> project?  If so a code clean up would be nice.  It would be one of those
> "we will do it someday" things, but nice none the less.

The horrible formatting in parted has been a very sore point with
everyone here for a long time.  Unfortunately, we can't fix it right now.

Well, maybe, slowly, a piece at a time.
There are multiple formatting/indentation styles, trailing blanks, etc.
All of that would be nice to "fix", but currently even removing trailing
blanks would cause massive trouble (merge conflicts) for "next" and vendor
patches.  I might try to make that small step, nonetheless.  We'll see.