[parted-devel] [PATCH] Properly sync partitions with operating system

Jim Meyering jim at meyering.net
Fri Feb 20 11:14:47 UTC 2009

Joel Granados <jgranado at redhat.com> writes:
>> > If the only values ever returned are non-negative (as it seems they are),
>> > then it'd be far more readable to make the return type "unsigned int".
>> > Otherwise, I have to wonder if some of these functions may return a
>> > negative value, and write code in each caller to handle that.
>> >
>> Seems like a good idea.  And: No, they are supposed to be possitive
>> values.  Note this will propagate into other elements of the patch as
>> well.
> On the other hand, ped_disk_get_max_partition would need to return -1

Yes, but that's a different function.

More information about the parted-devel mailing list