[parted-devel] [PATCH] When comparing use the same type of formats.

Jim Meyering jim at meyering.net
Fri Feb 20 12:21:12 UTC 2009


Joel Granados <jgranado at redhat.com> writes:
> On Thu, Feb 19, 2009 at 06:08:26PM +0100, Jim Meyering wrote:
>> Joel Granados Moreno <jgranado at redhat.com> writes:
>> > * libparted/labels/gpt.c (_parse_header()) : The problem is that
>> > last_usable_if_grown and last_usable_min_default should be both CPU
>> > format, but last_usable_if_grown is converted to LE64.  Patch taken from
>> > parted mailing list, author (petr.uzel at suse.cz).
>>
>> Thanks.
>> That patch looks like it's probably ok, but,
>> please run git commit --amend --author '...' and then adjust the log:
>> it need not mention authorship, since git's headers will do that.
>> Also, if you can include a URL for the message, that'd be nice,
>> especially if it includes more details, e.g., on how to produce the failure.
>>
>> If there is a convenient reproducer, let me know and I'll add a test.
>
> The url does not state additional.

Is there a problem report?

I'm wary of any patch that comes without a problem report
and without a recipe for reproducing some failure.



More information about the parted-devel mailing list