[parted-devel] [PATCH] Dont try to stat stuff that we know does not exist.

[Jim Meyering]

Joel Granados <jgranado at redhat.com> writes:
> On Thu, Feb 19, 2009 at 07:09:16PM +0100, Karel Zak wrote:
>> On Thu, Feb 19, 2009 at 06:14:26PM +0100, Jim Meyering wrote:
>> > Joel Granados Moreno <jgranado at redhat.com> writes:
>> > >     modified:   libparted/arch/linux.c:  When we look for stuff in
>> >
>> > Thanks!
>> >
>> > Please follow ChangeLog conventions, and use "*", not "modified:"
>> > and include parenthesized (function_names):
>> >
>> > * libparted/arch/linux.c (_mount_table_search): When we look for
>> >   directory names...
>> >
>> > >     /proc/mounts, /proc/swaps and /etc/mtab, there is a possibility to
>> > >     receive none path elements.  Like "none" or "tmpfs".  We are making
>> >
>> > Actually, a file named "none" or "tmpfs" *could* exist
>> > in the working directory, so this is a fix, not just an optimization.
>>
>>  What about:
>>
>>      //servername/path /mountpoint cifs options
>>
>>  the "//servername/path" could be also interpreted as a path ;-)

Good point.
Thanks, Karel.
>
> This is very true.  How about just ignoring the double slash as well?
> I'll post the second version of this.

Good! ;-)