[parted-devel] [PATCH] unneeded stats...

[Bryn M. Reeves]

Joel Granados Moreno wrote:
> Hello List
> 
> Here is the reviewed patch for the unneeded stats that we are doing when
> looking for mounted devices.  It is modified to not search for "server
> strings" (//servername/path/to/somewhere)
> 
> Review appreciated

There's a slight gotcha with this approach in that the kernel will 
honour the names that userspace gives it in a mount syscall. E.g. if I 
mount /dev/sda then that's what appears in /proc/mounts but if I mount 
//dev/sda, then that's the string that will appear.

E.g.:

# mount //dev/mapper/cyan /mnt
# grep cyan /proc/mounts
//dev/mapper/cyan /mnt ext3 rw,data=ordered 0 0

Which kinda breaks this heuristic. Technically although this is an odd 
way to reference the device it's not incorrect so I think our parsing 
of mount lists has to take it into account.

Regards,
Bryn.