[parted-devel] [PATCH] Detect Ext4 (Parted Alioth #188)

Debarshi Ray debarshi.ray at gmail.com
Wed Jan 7 04:45:46 UTC 2009


> make the test "skip" (not fail) if mkfs.ext4 fails.
> That may save us some reports of test failures on systems
> lacking ext4 support.

Two queries.

1. Can we use the test_skip function to skip one iteration of the for
loop? Or this is fine:
    which mkfs.$type >/dev/null 2>&1
    [ $? -eq 1 ] &&
        echo 'no $type support' &&
        continue

2. The $type is not getting expanded to ext[234] in the messages:
    [rishi at ginger tests]$ ./t1700-ext-probe.sh
    *   ok 1: create an $type file system
    *   ok 2: probe the $type file system
    *   ok 3: create an $type file system
    *   ok 4: probe the $type file system
    *   ok 5: create an $type file system
    *   ok 6: probe the $type file system
    * passed all 6 test(s)
    [rishi at ginger tests]$

Happy hacking,
Debarshi



More information about the parted-devel mailing list