[parted-devel] Parted Stuff that needs fixing before 1.8.9
Joel Granados
jgranado at redhat.com
Mon Jun 1 17:41:11 UTC 2009
On Mon, Jun 01, 2009 at 05:29:17PM +0200, Gilles Espinasse wrote:
>
> ----- Original Message -----
> From: "Joel Granados" <jgranado at redhat.com>
> To: "Parted Devel" <parted-devel at lists.alioth.debian.org>
> Sent: Monday, June 01, 2009 4:38 PM
> Subject: Re: [parted-devel] Parted Stuff that needs fixing before 1.8.9
>
>
> > Some comments on two issues. I share them with the list now, so I don't
> > forget in the near future when I am posting all the patches for the
> > bugs.
> >
> >
>
> > Still 6 issues to go. I will hopefully finish them by the end of the
> > week and we can begin the 1.8.9 release process.
> >
> > >
> > > 6. [parted-devel] [PATCH] backlist md devices from device list
> > > -
> http://lists.alioth.debian.org/pipermail/parted-devel/2009-April/002781.html
> > >
> > > 7. [parted-devel] [PATCH] document that primary keyword is not supported
> on sun label
> > > -
> http://lists.alioth.debian.org/pipermail/parted-devel/2009-April/002782.html
> > >
>
> If you want more details on 6 and 7, I am there listening.
Great! I have read the issue again and the patch idea seems ok.
> I have tested softraid working on sparc. I just suffered a bit before to
> have a working receipt to create the partition where the machine will boot
> from after installation.
> The sh script that do that well for me is at
> http://ipcop.svn.sourceforge.net/viewvc/ipcop/ipcop/trunk/src/scripts/disk-partition?revision=2757
This shell script seems very complete. Thx for the link.
What needs to be done for this fix to "go in" to parted is two things:
a. the patch needs to exist
b. the test for the issue needs to exists.
For a. One needs to create a patch using git and send it to the list
using git-format-patch. In that way it can easily be included in the
SRCs and your authorship will be maintained. For 6 at least I did not
find said patch, I have not yet looked at 7.
For b. One needs to create a test file in the /test directory that will
prove that the issue is resolved. like create a softraid and then list
the partitions and make sure that md-0 is not listed. Its not allways
easy because the test should run in a special contained maner.
If you have provided these two things (a and b), pls show me where they
are. If you have not provided them, it would be a great help for the
1.9.0 effort if you did so. It would save me two issues to worry about
and I could skip to 8... and we could be done before the end of the
week (hopefully)
If I have missunderstood your proposal, pls be so kind and correct me :)
Regards.
PS: you can ask for help with a and b in #parted (freenode). Im in
Central Europe, but I know otavio and others are in the americas and can
help you out.
--
Joel Andres Granados
Brno, Czech Republic, Red Hat.
More information about the parted-devel
mailing list