[parted-devel] [PATCH 7/9] A spec file is not necessary in the parted sources.

[Joel Granados]

On Fri, Jun 05, 2009 at 03:01:18PM +0200, Jim Meyering wrote:
> Joel Granados Moreno wrote:
> > We don't need it because parted is not distributed nor deployed using
> > RPM.
> >
> > * parted.spec.in: erased.
> 
> I have mixed feelings.
> It can be useful to maintain this file.  Doing so
> centralizes the information the file contains,
> and thus may help unify rpm-based distributions of parted.

I have to accept that your arguments are sound, but this just feels
wrong to me.  My reasons are:

1. The spec file depends on the context where parted is being built.
   Most of the variables in the spec file can differ from distro to distro.
   ATM, we have a spec file that fits fedora, and suse but it is far
   from generic.

2. This spec file has not way of stating that it contains proper
   spec file authoring practices.  This is only achieved within a distro
   and should be left to the distros to decide what exactly is sane and
   why.

3. Its something else that we need to worry about.  I would take the
   Changelog part out of it if it were to stay.  The changelog has
   specific stuff that other distributions just don't care about.  I
   just find it unnecessary.

> I'm leaning towards continuing to maintain this file,
> but don't feel very strongly about it.
> 
> However, if you were to remove the file, say "Remove file."
> in the log, not "erased".

Done.

> 
> More importantly, you would also have to remove mention
> of it and parted.spec from Makefile.am.

Done,  Sorry, didn't use distcheck before.  Will begin to use it....

> 
> Another good reason to run "make distchcheck".

Regards.

Ack.

> 
> > ---
> >  parted.spec.in |  103 --------------------------------------------------------
> >  1 files changed, 0 insertions(+), 103 deletions(-)
> >  delete mode 100644 parted.spec.in
> >
> > diff --git a/parted.spec.in b/parted.spec.in
> > deleted file mode 100644
> > index 7e697fe..0000000
> > --- a/parted.spec.in
> > +++ /dev/null
> > @@ -1,103 +0,0 @@
> > -# Default to disabling device-mapper and SELinux
> > -%define use_devmapper 0
> > -%define use_selinux 0
> > -%define use_sepol 0
> > -
> > -# Enable device-mapper support if we find devmapper
> > -%define use_devmapper %(pkg-config --libs devmapper >/dev/null 2>&1; [ $? -eq 0 ] && echo 1)
> > -
> > -# Enable SELinux if we find libselinux and libsepol
> > -%define use_selinux %([ -r %{_libdir}/libselinux.a ] && echo 1)
> > -%define use_sepol %([ -r %{_libdir}/libsepol.so ] && echo 1)
> > -
> > -Summary:   The GNU disk partition manipulation program
> > -Name:      @PACKAGE@
> > -Version:   @VERSION@
> > -Release:   1
> > -Source:    ftp://ftp.gnu.org/gnu/%{name}/%{name}-%{version}.tar.bz2
> > -Buildroot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
> > -License:   GPL
> > -Group:     Applications/System
> > -
> > -BuildRequires: e2fsprogs-devel readline-devel ncurses-devel
> > -BuildRequires: automake libtool gettext-devel texinfo pkgconfig
> > -
> > -BuildRequires: device-mapper-devel, libselinux-devel libsepol-devel
> > -
> > -Prereq: /sbin/install-info
> > -
> > -%description
> > -The GNU Parted program allows you to create, destroy, resize, move,
> > -and copy hard disk partitions. Parted can be used for creating space
> > -for new operating systems, reorganizing disk usage, and copying data
> > -to new hard disks.
> > -
> > -%package devel
> > -Summary:  Files for developing apps which will manipulate disk partitions
> > -Group:    Development/Libraries
> > -Requires: %{name}-%{version}-%{release}
> > -%description devel
> > -The GNU Parted library is a set of routines for hard disk partition
> > -manipulation. If you want to develop programs that manipulate disk
> > -partitions and filesystems using the routines provided by the GNU
> > -Parted library, you need to install this package.
> > -
> > -%prep
> > -%setup -q
> > -
> > -%build
> > -%configure \
> > -   --enable-shared \
> > -%if "%{use_devmapper}" == "1"
> > -   --enable-device-mapper \
> > -%else
> > -   --disable-devmapper \
> > -%endif
> > -%if "%{use_selinux}" == "1" && "%{use_sepol}" == "1"
> > -   --enable-selinux \
> > -%else
> > -   --disable-selinux \
> > -%endif
> > -   --enable-part-static \
> > -   --enable-pc98=no \
> > -   --enable-Werror=no \
> > -   --disable-dynamic-loading
> > -%{__make} %{?_smp_mflags}
> > -
> > -%install
> > -%{__rm} -rf %{buildroot}
> > -%{__make} install DESTDIR=%{buildroot}
> > -
> > -%clean
> > -%{__rm} -rf %{buildroot}
> > -
> > -%post -p /sbin/ldconfig
> > -
> > -%postun -p /sbin/ldconfig
> > -
> > -%files
> > -%defattr(-,root,root,-)
> > -%doc AUTHORS BUGS COPYING ChangeLog NEWS README THANKS TODO doc/API doc/FAT
> > -%{_sbindir}/parted
> > -%{_sbindir}/partprobe
> > -%{_mandir}/man8/parted.8.gz
> > -%{_mandir}/man8/partprobe.8.gz
> > -%{_libdir}/libparted-*.so.*
> > -%{_libdir}/libparted-*.so.*
> > -%{_infodir}/parted.info.gz
> > -
> > -%files devel
> > -%defattr(-,root,root,-)
> > -%{_includedir}/parted
> > -%{_libdir}/libparted.a
> > -%{_libdir}/libparted.so
> > -%{_libdir}/pkgconfig/libparted.pc
> > -
> > -%changelog
> > -* Tue Mar 13 2007 David Cantrell <dcantrell at redhat.com>
> > -- Updated spec file
> > -
> > -* Mon Mar 13 2000 Fabian Emmes <fab at orlen.de>
> > -- changed "unset LINGUAS" line
> > -- reintroduced %build section ;)
> > -- started changelog

-- 
Joel Andres Granados
Brno, Czech Republic, Red Hat.