[parted-devel] [PATCH 04/10] Add test to verify that the "md" devices are not getting listed.

Joel Granados jgranado at redhat.com
Thu Jun 11 09:10:53 UTC 2009


On Wed, Jun 10, 2009 at 09:15:32PM +0200, Jim Meyering wrote:
> Joel Granados Moreno wrote:
> 
> > * tests/t6001-dm-ignored.sh : New test file.
> > * tests/Makefile.am : add test to the test list.
> > ---
> ...
> Thanks.
> Applying with these changes:
> 
> > +which mdadm > /dev/null 2>&1 ||
> 
> Don't use "which".
> I'm replacing that with this:
> 
> +(mdadm --version) > /dev/null 2>&1 ||

Ack, Note that this is already fixed in at the end of the patch set.

> 
> > +  {
> > +    say "skipping $0: could not find mdadm executable"
> > +    test_done
> > +    exit
> > +  }
> > +
> > +# The md device.
> > +mddev_=
> > +
> > +cleanup_() {
> > +    mdadm --stop $mddev_ > /dev/null 2>&1
> > +    test -n "$d1" && losetup -d "$d1"
> > +    rm -f "$f1";
> > +}
> > +
> > +md_dev_create_()
> > +{
> > +  lo_dev=$1
> > +  mdd=$G_dev_/md0
> > +  for i in 0 1 2 3 4 5 6 7 8 9 ; do
> > +      mdd=$G_dev_/md$i
> > +      mdadm  --create --force $mdd --level=linear --raid-devices=1 $lo_dev > /dev/null 2>&1 \
> > +      && break
> 
> Line too long.  Wrap it:


oops,  good catch.

> 
>       mdadm  --create --force $mdd --level=linear --raid-devices=1 $lo_dev \
> 	  > /dev/null 2>&1 \
>         && break

-- 
Joel Andres Granados
Brno, Czech Republic, Red Hat.



More information about the parted-devel mailing list