[parted-devel] [PATCH] master branch
Joel Granados Moreno
jgranado at redhat.com
Wed May 13 15:24:29 UTC 2009
Hello list
This is a patch set that I have had in my git repo for some time now. I
really think these should go in. They are already in fedora.
One of these patches still has an unanswered comment from Otavio. The
suggestion was to split a commit to increase readability of the patches.
I still think that this should not be done. My additional reasons,
besides the ones I have already given in the previous thread with
Otavio, is that splitting the commit requires the addition of an ifdef
(and closing statement) that will immediately get erased once the move
is done. This, to me, seems illogical. I strongly suggest that this
patch remain as is. (691793483b48362f968d9567f2bf3656c9ba4e4e)
The patches have a pretty good explination in the commit messages. I do
want to address one issue that I encountered while I was doing the test
for the msdos-starting-sector patch. I noticed that I need to use
$(pwd) in the output strings. I did not notice this in any other tests.
If someone knows of a better way of formating that test, I am open to
suggestions.
As always, comments a greatly appreciated.
Regards.
Joel Andres Granados
Brno, Czech Republic, Red Hat.
More information about the parted-devel
mailing list