[parted-devel] [PATCH] master branch

[Jim Meyering]

Joel Granados Moreno wrote:
> Some stuff that I worked on today:
>
> 1. Make dmraid default.
> 2. Little change to make the syntax check work.
> 3. Move the partition_check from disk.c to the label files.

Does #3 fix a bug?  Haven't looked carefully yet.
If not, would you please target "next" instead?

On that branch there are new files, pt-tools.[ch]
for just that purpose.  There is such a blatant need
for factorization that I fear if we do anything significant
on master, we'll waste an inordinate amount of time merging
with the factorization changes I've begun on "next".

> I know that patch 3 introduces repeated code in two files.  I was going
> to address this by introducing a new file to the libparted/labels/
> directory called common.c or label_common.c or something like that.
> Where one can put stuff like that repeated function without compromising
> the modularity of the label abstraction.
>
> As always, comments a greatly appreciated.
>
> Regards.
>
> Joel Andres Granados
> Brno, Czech Republic, Red Hat.
>
> _______________________________________________
> parted-devel mailing list
> parted-devel at lists.alioth.debian.org
> http://lists.alioth.debian.org/mailman/listinfo/parted-devel