[parted-devel] [PATCH] Always allow at least two sectors for extended boot record

Jim Meyering jim at meyering.net
Sun Apr 18 09:29:58 UTC 2010


Phillip Susi wrote:
> On Tue, 13 Apr 2010 19:02:11 +0200
> Jim Meyering <jim at meyering.net> wrote:
>
>> Yes, actually that was exactly it.
>> I've since been able to show that the test does exercise the fix,
>> but the changes introduced failures in 2 or 3 root-only tests.
>> I think I've just fixed the last of those.
>>
>> I expect to push these two patches and associated changes tomorrow.
>
> Sorry, I don't quite understand this.  Are you saying that the 2 sector
> for extended boot record fix caused a test case failure?  Could you be
> more specific?

I've made some changes, and along the way some tests have failed
due to new semantics and new warnings.

I've pushed touched-up versions of your changes to a new, temporary
"next" branch

  http://git.debian.org/?p=parted/parted.git;a=shortlog;h=refs/heads/next

along with a new test and some clean-up and semantics-changing patches.
Also, with new semantics, I had to adjust tests.

One change to semantics is to adjust the warning so that it
makes parted exit nonzero.  Given that, perhaps the message should
start with "Error".

If you guys are happy with the changes, I'll pull "next" onto master.
Feedback welcome.



More information about the parted-devel mailing list