[parted-devel] [PATCH 0/2] parted: always print geometry

[Petr Uzel]

On Fri, Apr 16, 2010 at 09:50:38PM +0200, Jim Meyering wrote:
> Petr Uzel wrote:
> 
> > These two patch series makes parted print disk geometry even if given disk does
> > not contain valid partition table.
> >
> > Parted shipped with SUSE has similar patch for some time and one part
> > of SUSE's installer (libstorage) depends on it.
> > [...]
> 
> Thanks for the patches.
> Removing the unwarranted restriction is a welcome improvement.
> However, having to document when the change takes effect is unpalatable,
> because it doesn't make sense: why restrict it only to when we're using
> units of archaic CHS or cylinders?
> (sure, you and I know why, but that's an internal implementation detail)
> 
> Please change it so that it works regardless of which units are
> selected.  It's fine to print "?" in place of the partition table
> type name, when that is unknown.
> 
> A minor thing: since the new _print_disk_geometry doesn't write through
> its "dev" parameter, that parameter should have the "const" attribute:
> 
>     static void
>     _print_disk_geometry (PedDevice const *dev)
> 
> Also, please add a mention of this in NEWS, under "Changes in behavior".
> 
> It'd be great if you would add a test script that exercises
> the new behavior, but if you'd rather not, I will do it.

Thanks for the comments - I'll try to address them (including the
test) and resubmit ASAP.

BR,

Petr

--
Petr Uzel, openSUSE Boosters Team
IRC: ptr_uzl @ freenode
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/parted-devel/attachments/20100419/0772659f/attachment.pgp>