[parted-devel] [PATCH] tests: skip tests requiring mkfs.hfs if it is not available

[Petr Uzel]

On Mon, Mar 01, 2010 at 04:26:00PM +0100, Jim Meyering wrote:
> Petr Uzel wrote:
> > Testsuite fails if mkfs.hfs is not installed on the system.
> > * tests/t-lib.sh (_require_hfs): New function. The mkfs.hfs does
> 
> Thank you!
> Would you please adjust that to use something like this instead?
> 
>   ( mkfs.hfs | grep '^usage:' ) > /dev/null 2>&1 \
> 
> I prefer to avoid "which", because in some environments it is not available.
> Plus two nits in the log:
> 
> s/_require_hfs/require_hfs_/
> 
> >   not provide any option like --version, so 'which mkfs.hfs' is
> >   is used instead.
> > * tests/t3000-resize-fs.sh: Use _require_hfs
> 
> Likewise.

Jim, thanks for the suggestions. I'll adjust the patch and resend.


Petr

--
Petr Uzel, openSUSE Boosters Team
IRC: ptr_uzl @ freenode
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/parted-devel/attachments/20100301/b12d6bc7/attachment.pgp>