[PATCH] libparted: remove "HIGHLY EXPERIMENTAL" warning for >512B-sector devices

Jim Meyering meyering at redhat.com
Thu Mar 11 18:01:41 UTC 2010


* libparted/arch/linux.c (_device_set_sector_size): Remove the
"HIGHLY EXPERIMENTAL" warning, now that support for >512-byte sectors
seems to be usable.  Suggested by Colin Watson.
* NEWS (Changes in behavior): Note this
---
 NEWS                   |    6 ++++++
 libparted/arch/linux.c |   10 ----------
 2 files changed, 6 insertions(+), 10 deletions(-)

diff --git a/NEWS b/NEWS
index 77a10ca..1c7ad4a 100644
--- a/NEWS
+++ b/NEWS
@@ -13,6 +13,12 @@ GNU parted NEWS                                    -*- outline -*-
   Similarly, msdos_partition_get_flag(p,PED_PARTITION_HIDDEN) always returns 0
   for an extended partition.

+** Changes in behavior
+
+  libparted no longer issues an exception/warning about >512-byte
+  sector support being "HIGHLY EXPERIMENTAL".  It seems to have matured
+  enough to be usable at least with GPT and MSDOS partition tables.
+

 * Noteworthy changes in release 2.2 (2010-02-26) [stable]

diff --git a/libparted/arch/linux.c b/libparted/arch/linux.c
index 23d5b71..c75cf9e 100644
--- a/libparted/arch/linux.c
+++ b/libparted/arch/linux.c
@@ -687,16 +687,6 @@ _device_set_sector_size (PedDevice* dev)
                 dev->sector_size = PED_SECTOR_SIZE_DEFAULT;
         }
 #endif
-
-        if (dev->sector_size != PED_SECTOR_SIZE_DEFAULT) {
-                ped_exception_throw (
-                        PED_EXCEPTION_WARNING,
-                        PED_EXCEPTION_OK,
-                        _("Device %s has a logical sector size of %lld.  Not "
-                          "all parts of GNU Parted support this at the moment, "
-                          "and the working code is HIGHLY EXPERIMENTAL.\n"),
-                        dev->path, dev->sector_size);
-        }
 }

 static int
--
1.7.0.2.393.gfb6b



More information about the parted-devel mailing list