[parted-devel] Bug: Removal of BLKPG causes regression of ability to manipulate disks with other partitions in use

[Phillip Susi]

On 3/18/2010 12:17 PM, Hans de Goede wrote:
> I don't remember the exact details, but iirc the blkpg code worked by
> first removing all partitions, and re-adding them ignoring all
> errors in the process to allow "skipping" busy partitions.

It appears so.

> Only making it remove / re-add changed partitions would have required
> serious reworking of the code in question. So I opted for just throwing
> it out all together.
> 
> Also BLKPG does not work on all types of partitionable devices (it does
> not work for example on dasd disks).
> 
> Anyways, as said doing BLKPG correctly requires some significant
> reworking of the old code, patches welcome.

I'm taking a look at it now.  My first thought was to check for the
removal failure, and as long as you are about to add the partition back
exactly the same way, ignore it, otherwise, propagate the error up.
Does that sound good?