[parted-devel] Bug: Removal of BLKPG causes regression of ability to manipulate disks with other partitions in use

[Hans de Goede]

Hi,

On 03/18/2010 05:04 PM, Phillip Susi wrote:
> On 3/18/2010 11:45 AM, Hans de Goede wrote:
>> Hi,
>
> Hello ;)
>
>> It was removed because it lacked proper error checking, The 1.8 code was
>> ignoring BLKRRPART errors (such as for example those hrown by busy
>> partitions), which allowed one to modify partitions which are not in use.
>>
>> But this meant that no proper error checking was done, so if the user
>> did not exactly know what he was doing he parted would say all was fine,
>> while in reality the kernels view of the partitions did not match the
>> new layout. Since this is dangerous and error prone the use of
>> BLKRRPART was removed.
>
> Why not add error checking then instead of throwing it out altogether?
> Seems like curing the disease by killing the patient.

That would end up with the same result as we have now, the commit() would
fail as the BLKRRPART would fail on the in use partitions.

So by taking out the BLKRRPART we have the same end result with significantly
less code.

Regards,

Hans