[parted-devel] [PATCH 3/3] Use new BLKPG_GET_PARTITION ioctl to get partition start sector

[Phillip Susi]

On 12/2/2011 3:50 AM, Petr Uzel wrote:
> Looks good to me except mixing tabs and spaces indentation.

I was wondering about that.  At first it looked like most of the file currently uses spaces, so I untabified the file to change my tabs to spaces, and found that introduced a good deal of whitespace churn as there are a fair number of other lines using tabs.  What is the policy for tabs in parted?

> Hm, this code was hardly readable before and now with the ifdefs and
> ifndefs, it is even harder not to get lost in it. Perhaps this could
> be factored out somehow to separate function? Eventually also using
> /sys/block/DEV/PART/start as a fallback if the new ioctl() is not
> available?

Good idea, I'll get back to you with an update later today.