[parted-devel] [patch] Use 'p' partition separator only when necessary

Jim Meyering jim at meyering.net
Tue Dec 6 21:50:04 UTC 2011


Phillip Susi wrote:
> This seems to have fallen off the radar, so poking again.
>
> On 03/29/2011 03:34 PM, Jim Meyering wrote:
>> Phillip Susi wrote:
>>> On 3/11/2011 5:12 PM, Phillip Susi wrote:
>>>> It seems that the behavior was copied from dmraid, which decided a while
>>>> back to start adding the 'p' always.  Debian and Ubuntu have been
>>>> carrying a patch to reverse that change to both dmraid and parted.
>>>> Initially I got that patch dropped in Ubuntu during the Natty
>>>> development cycle because we want to avoid diverging from upstream, and
>>>> if the base device name ends in a digit, then you NEED the 'p' or
>>>> various tools get confused about what is the disk name and what is the
>>>> partition name.
>>>
>>> <snip>
>>>
>>> Just touching base to check on this since it's been two weeks with no
>>> response.
>>
>> Sorry it's taking so long.
>> If you had included a test suite addition,
>> I probably would have pushed your patch long ago.

Thanks for the reminder.
Can you write a test to exercise that patch, now?

IMHO, any significant bug-fix or change in parted
should be accompanied by a test suite addition that exercises it.



More information about the parted-devel mailing list