[parted-devel] [patch] Use 'p' partition separator only when necessary

[Jim Meyering]

Jim Meyering wrote:

> Phillip Susi wrote:
>> On 12/07/2011 11:44 AM, Jim Meyering wrote:
>>> Thanks for the new test.
>>> Unfortunately, at least on my F-16 (3.1.0-1.fc16.x86_64) desktop,
>>> it leads to creation of a hung and unkillable parted process
>>> that is running this command:
>>>
>>>     parted -s /pe/tests/gt-t6001-psep.sh.IQaO/root/dev/mapper/plinear-25167 \
>>>       mkpart primary fat32 1m 5m
>>>
>>> This will probably serve as impetus for me to reboot.
>>> Current uptime is a whopping 40 days, and a newer 3.1.4 kernel awaits.
>>
>> I had the same thing happen to me when running the test suite on your
>> master branch.  I tried to reproduce it, but couldn't.  There seems to
>> be a bug in the kernel somewhere.  I'm running Ubuntu's 3.2-rc3
>> kernel.
>>
>>> Two nits:
>>>
>>> When I applied that using "git am FILE", it complained about the two
>>> trailing spaces.  "make syntax-check" would have spotted those, too.
>>
>> Damn... I could have sworn I got those using whitespace mode in emacs.
>> Oh, I see, I thought those two spaces were required but I guess not.
>>
>> How's this one:
>
> Thanks for adjusting.
> I've confirmed that with the latest F16 kernel (3.1.5-1.fc16.x86_64),
> your new test passes:
>
>   sudo make -C tests check TESTS=t6001-psep.sh VERBOSE=yes
>
> so I've pushed it.
> Thanks again.

I've just realized that your change did not include a NEWS entry.
Would you please write one more patch to do that that?

Sorry I didn't notice it before pushing.