[parted-devel] [PATCH] tests: do not fail if some utilities are missing

Jim Meyering jim at meyering.net
Wed Mar 16 17:51:14 UTC 2011


Petr Uzel wrote:
> * tests/t1700-probe-fs.sh: Skip the test if mkfs.ext3 or tune2fs
> is missing or is not in $PATH.
>
> Signed-off-by: Petr Uzel <petr.uzel at suse.cz>
> ---
>  tests/t1700-probe-fs.sh |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/t1700-probe-fs.sh b/tests/t1700-probe-fs.sh
> index 749c9ea..21e72f9 100755
> --- a/tests/t1700-probe-fs.sh
> +++ b/tests/t1700-probe-fs.sh
> @@ -44,10 +44,10 @@ done
>  for feature in uninit_bg flex_bg; do
>    # create an ext3 file system
>    dd if=/dev/zero of=$dev bs=1024 count=4096 >/dev/null || fail=1
> -  mkfs.ext3 -F $dev >/dev/null || fail=1
> +  mkfs.ext3 -F $dev >/dev/null || skip_ "mkfs.ext3 failed"
>
>    # set the feature
> -  tune2fs -O $feature $dev || fail=1
> +  tune2fs -O $feature $dev || skip_ "tune2fs failed"
>
>    # probe the file system, which should now be ext4
>    parted -m -s $dev u s print >out 2>&1 || fail=1

Thanks.
I've pushed that as-is.



More information about the parted-devel mailing list