[PATCH] tests: add a NEWS entry and a test to exercise today's bug fix

[Jim Meyering]

* tests/t9041-undetected-in-use-16th-partition: New file.
* tests/Makefile.am (TESTS): Add it.
* NEWS (Bug fixes): Describe it.
---
 NEWS                                            |    5 +
 tests/Makefile.am                               |    3 +-
 tests/t9041-undetected-in-use-16th-partition.sh |   99 +++++++++++++++++++++++
 3 files changed, 106 insertions(+), 1 deletions(-)
 create mode 100644 tests/t9041-undetected-in-use-16th-partition.sh

diff --git a/NEWS b/NEWS
index 92e8ea7..0ac69c8 100644
--- a/NEWS
+++ b/NEWS
@@ -4,6 +4,11 @@ GNU parted NEWS                                    -*- outline -*-

 ** Bug fixes

+  parted no longer allows the modification of certain in-use partitions.
+  In particular, before this fix, parted would permit removal or modification
+  of any in-use partition on a dmraid and any in-use partition beyond the 15th
+  on a regular scsi disk.
+
   Improve support of DASD devices on the s390 architecture.
   Parted now supports all DASD types (CKD and FBA), DASD formats (CDL,
   LDL, CMS non-reserved, and CMS reserved), and DASD drivers (ECKD, FBA,
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 93e5995..df9711c 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -47,7 +47,8 @@ TESTS = \
   t9020-alignment.sh \
   t9021-maxima.sh \
   t9030-align-check.sh \
-  t9040-many-partitions.sh
+  t9040-many-partitions.sh \
+  t9041-undetected-in-use-16th-partition.sh

 EXTRA_DIST = \
   $(TESTS) lvm-utils.sh t-local.sh t-lvm.sh \
diff --git a/tests/t9041-undetected-in-use-16th-partition.sh b/tests/t9041-undetected-in-use-16th-partition.sh
new file mode 100644
index 0000000..74c30fc
--- /dev/null
+++ b/tests/t9041-undetected-in-use-16th-partition.sh
@@ -0,0 +1,99 @@
+#!/bin/sh
+# Ensure that parted knows when N'th (N>=16) partition is mounted
+
+# Copyright (C) 2010-2011 Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+. "${srcdir=.}/init.sh"; path_prepend_ ../parted
+
+require_root_
+require_scsi_debug_module_
+
+grep '^#define USE_BLKID 1' "$CONFIG_HEADER" > /dev/null ||
+  skip_ 'this system lacks a new-enough libblkid'
+
+ss=$sector_size_
+partition_sectors=256  # sectors per partition
+n_partitions=17        # how many partitions to create
+start=2048             # start sector for the first partition
+gpt_slop=34            # sectors at end of disk reserved for GPT
+
+n_sectors=$(($start + n_partitions * partition_sectors + gpt_slop))
+
+sectors_per_MiB=$((1024 * 1024 / ss))
+n_MiB=$(((n_sectors + sectors_per_MiB - 1) / sectors_per_MiB))
+# create memory-backed device
+scsi_debug_setup_ sector_size=$ss dev_size_mb=$n_MiB > dev-name ||
+  skip_ 'failed to create scsi_debug device'
+scsi_dev=$(cat dev-name)
+
+n=$((n_MiB * sectors_per_MiB))
+printf "BYT;\n$scsi_dev:${n}s:scsi:$ss:$ss:gpt:Linux scsi_debug;\n" \
+  > exp || fail=1
+
+parted -s $scsi_dev mklabel gpt || fail=1
+parted -s $scsi_dev u s p || fail=1
+
+i=1
+t0=$(date +%s.%N)
+while :; do
+    end=$((start + partition_sectors - 1))
+    parted -s $scsi_dev mkpart p$i ${start}s ${end}s || fail=1
+    printf "$i:${start}s:${end}s:${partition_sectors}s::p$i:;\n" >> exp
+    test $i = $n_partitions && break
+    start=$((start + partition_sectors))
+    i=$((i+1))
+done
+t_final=$(date +%s.%N)
+
+# Fail the test if it takes too long.
+# On Fedora 13, it takes about 15 seconds.
+# With older kernels, it typically takes more than 150 seconds.
+$AWK "BEGIN {d = $t_final - $t0; n = $n_partitions; st = 60 < d;"\
+' printf "created %d partitions in %.2f seconds\n", n, d; exit st }' /dev/null \
+    || fail=1
+
+parted -m -s $scsi_dev u s p > out || fail=1
+compare out exp || fail=1
+
+wait_for_dev_to_appear_ ${scsi_dev}16 || fail_ ${scsi_dev}16 did not appear
+
+partitions="${scsi_dev}14 ${scsi_dev}15 ${scsi_dev}16"
+for i in $partitions; do
+  mkfs.ext3 $i || skip_ mkfs.ext3 $i failed
+done
+
+# be sure to unmount upon interrupt, failure, etc.
+cleanup_fn_() { for i in $partitions; do umount "$i" > /dev/null 2>&1; done; }
+
+for part_dev in $partitions; do
+  n=${part_dev#$scsi_dev}
+  mount_point=$(pwd)/m-$n
+  mkdir $mount_point || fail=1
+  mount "$part_dev" "$mount_point" || fail=1
+
+  # Removal of mounted partition must fail.
+  parted -s $scsi_dev rm $n > out 2>&1 && fail=1
+
+  echo "Error: Partition $part_dev is being used." \
+	  'You must unmount it before you modify it with Parted.' \
+    > exp-error || framework_failure_
+
+  # expect error
+  compare out exp-error || fail=1
+
+done
+
+Exit $fail
--
1.7.5.1.354.g761178