[parted-devel] [PATCH 1/2] libparted: copy flags when duplicating GPT partitions

[Brian C. Lane]

On Wed, Nov 02, 2011 at 05:09:32PM +0100, Jim Meyering wrote:
> 
> Hi Brian,
> 
> Thanks for that fix, and especially for the added test case (which I'm
> about to look at).  Does this have an associated bugzilla number?
> If so, let me know and I'll mention it in the log message before I push.

Yes, it is 747497

I had a particularly hard time getting that test case working, so if you
see anything wrong with it let me know. The creation of the example
partition was harder than I expected it to be. It doesn't work with all
disk labels as I was hoping, but msdos, gpt and bsd should cover the
majority of uses.

> 
> From a maintainability standpoint, I'll adjust it just to copy the entire
> struct; then there's no need to adjust whenever we add a new flag:

I wasn't sure if that was safe to do for all arches so I opted for brute
force :)

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 482 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/parted-devel/attachments/20111102/8f46a92a/attachment.pgp>